-
Notifications
You must be signed in to change notification settings - Fork 2.3k
release v1.9.1 #1683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release v1.9.1 #1683
Conversation
WalkthroughThe changelog was updated to include a new version entry, v1.9.1, dated March 21, 2025. This update introduces a new Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Client
participant DSNFormatter
participant Driver
User->>Client: Initiate connection with Charset() option
Client->>DSNFormatter: Format DSN (apply Charset & ConnectionAttributes)
DSNFormatter-->>Client: Return formatted DSN
Client->>Driver: Connect using DSN
Driver-->>Client: Connection established
Possibly related PRs
Suggested reviewers
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
CHANGELOG.md (1)
5-8
: Major Changes Section is Concise and Informative
The addition of the bullet point for major changes (* Add Charset() option. (#1679)
) immediately informs the reader about the new feature. Consider cross-referencing or linking to the updated documentation if further details are available elsewhere in the repo.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
CHANGELOG.md
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: test (windows-latest, 1.23, mariadb-10.11)
- GitHub Check: test (windows-latest, 1.23, mariadb-11.2)
- GitHub Check: test (windows-latest, 1.23, mariadb-11.4)
🔇 Additional comments (2)
CHANGELOG.md (2)
3-4
: New Version Entry Formatting is Clear and Consistent
The new version entry## v1.9.1 (2025-03-21)
is formatted consistently with previous entries and includes a correct date. This clearly sets the stage for the release notes.
9-12
: Bugfixes Section Provides Clear Reference to Resolved Issues
The bugfix entries (* go.mod: fix go version format (#1682)
and* Fix FormatDSN missing ConnectionAttributes (#1619)
) succinctly highlight the issues resolved. Confirm that the corresponding issues are well-documented and that any related tests have been updated or added, as outlined in the PR checklist.
Description
Checklist
Summary by CodeRabbit
New Features
Bug Fixes