Skip to content

release v1.9.1 #1683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 21, 2025
Merged

release v1.9.1 #1683

merged 2 commits into from
Mar 21, 2025

Conversation

methane
Copy link
Member

@methane methane commented Mar 14, 2025

Description

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

Summary by CodeRabbit

  • New Features

    • Introduces a new configuration option to customize character settings.
  • Bug Fixes

    • Resolved an issue with version display.
    • Fixed a connection configuration problem to improve overall stability.

Copy link

coderabbitai bot commented Mar 14, 2025

Walkthrough

The changelog was updated to include a new version entry, v1.9.1, dated March 21, 2025. This update introduces a new Charset() option and records two bug fixes: one for the Go version formatting in go.mod and another addressing a missing ConnectionAttributes in FormatDSN.

Changes

File Summary
CHANGELOG.md Added new version entry v1.9.1 (2025-03-21); introduced Charset() option; noted bug fixes for go.mod version format (#1682) and for missing ConnectionAttributes in FormatDSN (#1619).

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Client
    participant DSNFormatter
    participant Driver

    User->>Client: Initiate connection with Charset() option
    Client->>DSNFormatter: Format DSN (apply Charset & ConnectionAttributes)
    DSNFormatter-->>Client: Return formatted DSN
    Client->>Driver: Connect using DSN
    Driver-->>Client: Connection established
Loading

Possibly related PRs

Suggested reviewers

  • shogo82148

Poem

I'm a rabbit, quick and spry,
Hopping through the code under a bright sky.
With Charset leaping into view,
Bug fixes align—precise and true.
Cheers from my burrow with a joyful sigh!
🐇 Happy coding, let's give it a try!


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@coveralls
Copy link

coveralls commented Mar 14, 2025

Coverage Status

coverage: 82.959%. remained the same
when pulling af0c6ef on methane:release-v191
into b84ac5a on go-sql-driver:master.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
CHANGELOG.md (1)

5-8: Major Changes Section is Concise and Informative
The addition of the bullet point for major changes (* Add Charset() option. (#1679)) immediately informs the reader about the new feature. Consider cross-referencing or linking to the updated documentation if further details are available elsewhere in the repo.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4f48b46 and af0c6ef.

📒 Files selected for processing (1)
  • CHANGELOG.md (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: test (windows-latest, 1.23, mariadb-10.11)
  • GitHub Check: test (windows-latest, 1.23, mariadb-11.2)
  • GitHub Check: test (windows-latest, 1.23, mariadb-11.4)
🔇 Additional comments (2)
CHANGELOG.md (2)

3-4: New Version Entry Formatting is Clear and Consistent
The new version entry ## v1.9.1 (2025-03-21) is formatted consistently with previous entries and includes a correct date. This clearly sets the stage for the release notes.


9-12: Bugfixes Section Provides Clear Reference to Resolved Issues
The bugfix entries (* go.mod: fix go version format (#1682) and * Fix FormatDSN missing ConnectionAttributes (#1619)) succinctly highlight the issues resolved. Confirm that the corresponding issues are well-documented and that any related tests have been updated or added, as outlined in the PR checklist.

@methane methane merged commit 1fbafa8 into go-sql-driver:master Mar 21, 2025
38 checks passed
@methane methane deleted the release-v191 branch March 21, 2025 02:04
This was referenced Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants