no panic on closed connection reuse #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
http://play.golang.org/p/tGf3r4UtFS |
| @@ -108,6 +108,40 @@ func (dbt *DBTest) mustQuery(query string, args ...interface{}) (rows *sql.Rows) | |||
| return rows | |||
| } | |||
|
|
|||
| func TestClosedConnection(t *testing.T) { | |||
There was a problem hiding this comment.
TestReuseClosedConnection
|
I won't merge until you LGTM it again because I don't handle |
|
LGTM |
arnehormann
added a commit
that referenced
this pull request
Oct 30, 2013
no panic on closed connection reuse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #142
I'm not sure if this is good to go yet. The test should probably be expanded, it doesn't test all cases I fixed.
Let's take it as a basis for a discussion.
I didn't see a central place to add the checks and I'm not sure if I missed some relevant ones.
How this was created:
I located the places to fix by searching for
mysql(Stmt|Conn|Tx|Rows)\) [A-Z]in all go files. Those are the only structs containing (or beeing)mysqlConn, the exported functions as entry points should suffice for the check and make sure it's not "overchecked".I changed the
mc.netConnchecks tomc.bufin existing code to keep the checked condition the same everywhere. I did not check the disassembled object code for this being faster than comparingmc.netConn == nilor writing a small func which is or is not inlined.