Skip to content

Ignore user exception when RejectReadOnly #1320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Ignore user exception when RejectReadOnly #1320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6fb9b6e
Ignore SQLSTATE '45000' when RejectReadOnly is set
thopos Apr 6, 2022
a0b5ef3
AUTHORS: add 'dyves labs AG'
thopos Apr 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions AUTHORS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ Ziheng Lyu <zihenglv at gmail.com>
Barracuda Networks, Inc.
Counting Ltd.
DigitalOcean Inc.
dyves labs AG
Facebook Inc.
GitHub Inc.
Google Inc.
Expand Down
20 changes: 11 additions & 9 deletions packets.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -571,9 +571,19 @@ func (mc *mysqlConn) handleErrorPacket(data []byte) error {
// Error Number [16 bit uint]
errno := binary.LittleEndian.Uint16(data[1:3])

pos := 3

// SQL State [optional: # + 5bytes string]
var sqlstate string
if data[3] == 0x23 {
sqlstate = string(data[4 : 4+5])
pos = 9
}

// 1792: ER_CANT_EXECUTE_IN_READ_ONLY_TRANSACTION
// 1290: ER_OPTION_PREVENTS_STATEMENT (returned by Aurora during failover)
if (errno == 1792 || errno == 1290) && mc.cfg.RejectReadOnly {
// SQLSTATE 45000: user-defined exception
if (errno == 1792 || errno == 1290) && sqlstate != "45000" && mc.cfg.RejectReadOnly {
// Oops; we are connected to a read-only connection, and won't be able
// to issue any write statements. Since RejectReadOnly is configured,
// we throw away this connection hoping this one would have write
Expand All @@ -587,14 +597,6 @@ func (mc *mysqlConn) handleErrorPacket(data []byte) error {
return driver.ErrBadConn
}

pos := 3

// SQL State [optional: # + 5bytes string]
if data[3] == 0x23 {
//sqlstate := string(data[4 : 4+5])
pos = 9
}

// Error Message [string]
return &MySQLError{
Number: errno,
Expand Down