Improve readability follows `go-staticcheck` #1227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

shogo82148 merged 1 commit into go-sql-driver:master from zihengCat:go-staticcheck-improve

Jun 30, 2021

Contributor

zihengCat commented Jun 29, 2021 •

edited

Loading

Description

Improve readability follows go-staticcheck:

Use division assignment operator in function parseByteYear.
Remove unnecessary break in dsn.go.
Use clear bytes.Equal API.

Checklist

Code compiles correctly
Created tests which fail without the change (if possible)
All tests passing
Extended the README / documentation, if necessary
Added myself / the copyright holder to the AUTHORS file


          improve readability follows go-staticcheck

acd015e

sign in AUTHORS

Contributor Author

zihengCat commented Jun 29, 2021

@julienschmidt
Hi, take a review pls :)

shogo82148 approved these changes

View reviewed changes

Contributor

shogo82148 left a comment

LGTM

Contributor

shogo82148 commented Jun 30, 2021

some test fail but it's not due to this pull request.
so I'm going to merge it.

shogo82148 merged commit 21f789c into go-sql-driver:master

zihengCat deleted the go-staticcheck-improve branch

June 30, 2021 03:34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet