Skip to content

Wording correction in README #1218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 3, 2021
Merged

Wording correction in README #1218

merged 2 commits into from
Jun 3, 2021

Conversation

jvedock
Copy link
Contributor

@jvedock jvedock commented Jun 3, 2021

Description

there was a flow of text error in the readme, specifically, I changed,
opened and closed very frequently than you expect
to
opened and closed much more frequently than you expect
in the section about important settings, under usage

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

julienschmidt
julienschmidt approved these changes Jun 3, 2021
View reviewed changes
Copy link
Member

@julienschmidt julienschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@julienschmidt julienschmidt merged commit e74ba5c into go-sql-driver:master Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienschmidt julienschmidt julienschmidt approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jvedock @julienschmidt