Skip to content

Use Full Semantic Version Numbers (vgo) #793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
markbates opened this issue May 14, 2018 · 1 comment
Closed

Use Full Semantic Version Numbers (vgo) #793

markbates opened this issue May 14, 2018 · 1 comment

Comments

@markbates
Copy link

When trying to build gobuffalo/pop with golang.org/x/vgo I discovered that the version numbers that this package uses v1.3 are not compatible with vgo as it is very strict about semantic version numbers.

Because of this, the only build of this package that will work with vgo is v1.0.3. Switched to full semvar numbers, like v1.3.0 will correct this problem.

Steps to reproduce

  • main.go
package main

import (
	"fmt"

	_ "github.com/go-sql-driver/mysql"
)

func main() {
	fmt.Println("hello")
}
  • go.mod
module myvgo

Run:

$ vgo build -v .

The go.mod is updated to the "last" semvar number it can find, v1.0.3, not v1.3

module myvgo

require github.com/go-sql-driver/mysql v1.0.3

Altering the go.mod file to use the v1.3 rev:

module myvgo

require github.com/go-sql-driver/mysql v1.3
$ vgo build -v .
invalid module version "v1.3": unknown revision "v1.3.0"
@julienschmidt
Copy link
Member

Duplicate of #763. Should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants