Skip to content

Some release tags aren't semver #763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jamie-digital opened this issue Mar 2, 2018 · 2 comments
Closed

Some release tags aren't semver #763

jamie-digital opened this issue Mar 2, 2018 · 2 comments
Milestone

Comments

@jamie-digital
Copy link

Issue description

The latest release (v1.3) isn't semver, so vgo breaks when trying to fetch v1.3.0, as the tag doesn't exist.

Example code

$ vgo get github.com/go-sql-driver/[email protected]

Error log

vgo: finding github.com/go-sql-driver/mysql v1.3.0
vgo: github.com/go-sql-driver/mysql v1.3.0: unexpected status (https://api.github.com/repos/go-sql-driver/mysql/git/refs/tags/v1.3.0): 404 Not Found
vgo: finding github.com/go-sql-driver/mysql v1.3.0
vgo: github.com/go-sql-driver/mysql v1.3.0: unexpected status (https://api.github.com/repos/go-sql-driver/mysql/git/refs/tags/v1.3.0): 404 Not Found
vgo: unexpected status (https://api.github.com/repos/go-sql-driver/mysql/git/refs/tags/v1.3.0): 404 Not Found

Configuration

Driver version (or git SHA): v1.3

Go version: go version go1.10 darwin/amd64, go version go1.10 darwin/amd64 vgo:2018-02-20.1

Server version: N/A

Server OS: macOS 10.13.2

@jamie-digital
Copy link
Author

This would be fixed by:

git tag -a v1.3.0 v1.3 -m "Tagged v1.3 as v1.3.0"

@julienschmidt julienschmidt added this to the v1.4.0 milestone Mar 3, 2018
@julienschmidt
Copy link
Member

Fixed. I preserved the old tags for backwards-compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants