-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Allow dialers and TLS configuration to be added directly to MySQLDriver type #771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
ref: #705 |
Ah, I see. Seems like that PR would be closer to what I want, but IIUC the |
Ran into this today. Glad to see driver.Connector implemented, but TLS config is not possible without doing parseDSN since cfg.tls is not exported and is only added via ParseDSN |
+1, would love to see ability to create a driver.Connector from a net.Conn. The caller can set up tls if necessary. |
I dislike registry APIs, and I want to add this too. But before adding this, we need to decide what should we do for |
I would like to be able to create MySQL connections with custom TLS configuration and dialers without modifying the package-global registries, especially now that Go 1.10's
OpenDB
function is available. If the same register functions were available as methods on the driver and modifying a particular driver's state, that would go a long way.Happy to send a PR to fix.
The text was updated successfully, but these errors were encountered: