-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Column Valuers broken since #690 #708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
|
randomjunk
added a commit
to randomjunk/mysql
that referenced
this issue
Nov 16, 2017
…rnally Added a test that Valuer types are handled correctly. This test fails without the fix. CheckNamedValue code was included recently and breaks existing applications: go-sql-driver#690 Reported in: go-sql-driver#708
randomjunk
added a commit
to randomjunk/mysql
that referenced
this issue
Nov 16, 2017
…rnally Added a test that Valuer types are handled correctly. This test fails without the fix. CheckNamedValue code was included recently and breaks existing applications: go-sql-driver#690 Reported in: go-sql-driver#708
4 tasks
5 tasks
bLamarche413
pushed a commit
to bLamarche413/mysql
that referenced
this issue
Mar 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue description
Implement a struct with Valuer and use it as a named value in SQL statement.
We expect it to convert to driver.Value and work.
Our current code does this all over the place (using gorm).
The problem is that the recent change to named value handling (#690) returns a hard error if it can't convert the type, whereas it should return
driver.ErrSkip
to allow the default converter to handle it.Example code
Error log
The text was updated successfully, but these errors were encountered: