Skip to content

feat:add code comments & refactor mysql config constant #826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 8, 2023

Conversation

CocaineCong
Copy link
Contributor

add code comments:

I found the code comments of this program are not enough which make the program hardly to understand...
so I add some code comments through my understanding of the program.

refactor mysql config constant

I just remove the mysql default constant to the same file.

@CocaineCong
Copy link
Contributor Author

CocaineCong commented Oct 7, 2023

PTAL, sorry for my bad pr. I’m try my best to understand this project. 🥲

Copy link
Collaborator

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't worry, any contribution is welcome

@lance6716 lance6716 merged commit 3606141 into go-mysql-org:master Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants