Add some TableMapEvent helper methods #482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
@csuzhangxc PTAL, if there're not any problems, we can merge this PR ASAP |
csuzhangxc
reviewed
Jun 21, 2020
replication/row_event.go
Outdated
| func (e *TableMapEvent) realType(i int) byte { | ||
|
|
||
| typ := e.ColumnType[i] | ||
| meta := e.ColumnMeta[i] |
There was a problem hiding this comment.
How about putting this line above L748?
|
|
||
| case MYSQL_TYPE_GEOMETRY: | ||
| if e.flavor == "mariadb" { | ||
| return true |
There was a problem hiding this comment.
How about highlight this special behavior as the comments of this func (IsCharacterColumn)?
Move some code in TableMapEvent.realType
huangjunwen
added a commit
to huangjunwen/golibs
that referenced
this pull request
Jun 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds some type-related helper methods for
TableMapEvent. #479They should behave the same as
Table_map_log_event::print_columns(mysqlbinlog --print-table-metadata).And a
flavorfield is added toBinlogParserand passed toTableMapEventto distinguish mysql/mariadb, since there are some differences slightly in checking types.