replication: support parsing event with header only and no checksum #431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
When parsing a binlog event that has event header only and no checksum data, go-mysql will return error
invalid event header, event size is 19, too smallRef to MySQL doc,
STOP_EVENThas event header only, so if binlog checksum is not enabled, there may exist binlog event with event size 19.Besides the binlog event checksum was disabled by default before MariaDB 10.2.1, so this problem occurs often in MariaDB 10.1.x
What is changed and how it works?
Allow binlog event size equals to 19