fix(canal): fix mysql unsigned medium int #399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddontang
reviewed
Jul 8, 2019
canal/rows.go
Outdated
| @@ -57,7 +58,14 @@ func (r *RowsEvent) handleUnsigned() { | |||
| case int16: | |||
| r.Rows[i][index] = uint16(t) | |||
| case int32: | |||
| r.Rows[i][index] = uint32(t) | |||
| if strings.Contains(strings.ToLower(r.Table.Columns[i].RawType), "mediumint") { | |||
There was a problem hiding this comment.
interesting, can you add some comments here?
maybe it is better to add a test.
There was a problem hiding this comment.
Maybe the implementation from gh-ost is better and more clear?
There was a problem hiding this comment.
@siddontang added comments and test.
@NearTan I think so, thanks.
There was a problem hiding this comment.
Maybe we can do more, to add a similar MediumIntColumnType.
I worry that comparing string every time can reduce the performance.
Ryan-Git
force-pushed
the
fix-mysql-unsigned-mediumint
branch
from
591d64f to
7a090e8
Compare
|
CI failed |
|
fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is port from moiot/gravity#182.
the problem is we use int32 to receive mysql medium int value, which is 3 bytes. When it's unsigned, simply do a type cast is not sufficient.