Issue #26 sign-extend int8/int16/int24/int32 when widening to int64 #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -39,7 +39,7 @@ func (p RowData) ParseText(f []*Field) ([]interface{}, error) { | |||
| if isNull { | |||
| data[i] = nil | |||
| } else { | |||
| isUnsigned = (f[i].Flag&UNSIGNED_FLAG > 0) | |||
| isUnsigned := f[i].Flag & UNSIGNED_FLAG != 0 | |||
There was a problem hiding this comment.
small style change--advantage being that the var isUnsigned can't be read without having being properly initialized
|
Cool, @karmakaze , I will see it later, Thank you. |
|
Hi @karmakaze , can you add some tests? |
|
I can see about adding some tests over the weekend. This library has been working out pretty well so far. Performance so far hasn't been an issue, so just looking at correctly handling all the datatypes we're using. |
…o int64) Adds funcs mysql.ParseBinaryInt8/Uint8/Int16/Uint16/Int24/Uint24/Int32/Uint32/Int64/Uint64 and tests
karmakaze
force-pushed
the
sign-extend-ints-when-widening
branch
from
2e121d1 to
879f46c
Compare
|
Added tests, put common implementation in mysql/parse_binary.go used by mysql/resultset.go and replication/row_event.go |
|
LGTM, Thank you @karmakaze |
siddontang
added a commit
that referenced
this pull request
Jan 11, 2016
Issue #26 sign-extend int8/int16/int24/int32 when widening to int64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.