Skip to content

Theme arc-green: reverse heatmap colors #8840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 6, 2019
Merged

Theme arc-green: reverse heatmap colors #8840

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1541456
Theme arc-green: reverse heatmap colors
cdlm Nov 5, 2019
3248ca3
Use link color as hot, interpolate between hot and cold colors
cdlm Nov 6, 2019
da1a0ed
Rebuild CSS
cdlm Nov 5, 2019
0ba375d
Use color from a:hover
cdlm Nov 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions public/css/theme-arc-green.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,11 @@ a.ui.label:hover,a.ui.labels .label:hover{background-color:#505667!important;col
.xdsoft_datetimepicker .xdsoft_datepicker .xdsoft_calendar td,.xdsoft_datetimepicker .xdsoft_datepicker .xdsoft_calendar th{border-color:#4c505c;background-color:#2a2e39}
.xdsoft_datetimepicker .xdsoft_datepicker .xdsoft_calendar td.xdsoft_disabled,.xdsoft_datetimepicker .xdsoft_datepicker .xdsoft_calendar td.xdsoft_other_month{opacity:.8;background:#a0cc75;color:#000}
.heatmap-color-0{background-color:#2d303b}
.heatmap-color-1{background-color:#3f4943}
.heatmap-color-2{background-color:#51614b}
.heatmap-color-3{background-color:#637a53}
.heatmap-color-4{background-color:#75925b}
.heatmap-color-5{background-color:#87ab63}
.CodeMirror{color:#9daccc;background-color:#2b2b2b;border-top:0}
.CodeMirror div.CodeMirror-cursor{border-left:1px solid #9e9e9e}
.CodeMirror .CodeMirror-gutters{background-color:#2b2b2b}
Expand Down
28 changes: 27 additions & 1 deletion public/less/themes/arc-green.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1294,8 +1294,34 @@ a.ui.labels .label:hover {
}
}

.heatmap(@heat) {
@heatmap-cold: #2d303b;
@heatmap-hot: #87ab63;
Copy link
Member

@sapk sapk Nov 6, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can use the color for a:hover (#a0cc75) which is a little brighter ? I feel like the heatmap is too dark now 😄

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And how #00FF48 looks? (i can't imagine)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With #a0cc75 from a:hover (I like it):
Screenshot 2019-11-06 at 16 08 59

With #00ff48 it looks out of place IMHO… too vibrant compared to the rest of the theme:
Screenshot 2019-11-06 at 16 12 08

background-color: mix(@heatmap-hot, @heatmap-cold, @heat);
}

.heatmap-color-0 {
background-color: #2d303b;
.heatmap(0%);
}

.heatmap-color-1 {
.heatmap(20%);
}

.heatmap-color-2 {
.heatmap(40%);
}

.heatmap-color-3 {
.heatmap(60%);
}

.heatmap-color-4 {
.heatmap(80%);
}

.heatmap-color-5 {
.heatmap(100%);
}

/* code mirror dark theme */
Expand Down