Skip to content

Expose db.SetMaxOpenConns and allow non MySQL dbs to set conn pool params #8528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Oct 21, 2019
Merged

Expose db.SetMaxOpenConns and allow non MySQL dbs to set conn pool params #8528

Changes from 4 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
4cdd0e0
Expose db.SetMaxOpenConns and allow other dbs to set their connection…
zeripath Oct 15, 2019
03dbb9b
Apply suggestions from code review
zeripath Oct 16, 2019
1808652
Update modules/setting/database.go
zeripath Oct 16, 2019
57d98a3
Update go fmt
zeripath Oct 16, 2019
039c87d
Merge branch 'master' into expose-dbconfiguration-params
zeripath Oct 16, 2019
3d849ff
Update docs/content/doc/advanced/config-cheat-sheet.en-us.md
zeripath Oct 16, 2019
baa17bc
Apply suggestions from code review
zeripath Oct 16, 2019
db0c535
Move the order of setting around
zeripath Oct 18, 2019
07bd579
Merge branch 'master' into expose-dbconfiguration-params
zeripath Oct 21, 2019
156966d
Add note about port exhaustion
zeripath Oct 21, 2019
edabc2f
Update docs/content/doc/advanced/config-cheat-sheet.en-us.md
zeripath Oct 21, 2019
5788827
Update docs/content/doc/advanced/config-cheat-sheet.en-us.md
zeripath Oct 21, 2019
eeeb597
Slight reword
zeripath Oct 21, 2019
410565b
Merge branch 'master' into expose-dbconfiguration-params
zeripath Oct 21, 2019
f1ba0ab
Merge branch 'master' into expose-dbconfiguration-params
zeripath Oct 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/content/doc/advanced/config-cheat-sheet.en-us.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,9 +192,9 @@ Values containing `#` or `;` must be quoted using `` ` `` or `"""`.
- `LOG_SQL`: **true**: Log the executed SQL.
- `DB_RETRIES`: **10**: How many ORM init / DB connect attempts allowed.
- `DB_RETRY_BACKOFF`: **3s**: time.Duration to wait before trying another ORM init / DB connect attempt, if failure occured.
- `MAX_IDLE_CONNS` **2**: Max idle database connections on connnection pool, default is 2
- `CONN_MAX_LIFETIME` **0 or 3s**: Sets the maximum amount of time a DB connection may be reused - default is 0, meaning there is no limit (except on MySQL where it is 3s - see #6804 & #7071)
- `MAX_OPEN_CONNS` **0**: Database maximum open connections - default is 0, meaning there is no limit.
- `MAX_IDLE_CONNS` **2**: Max idle database connections on connnection pool, default is 2 - this will be capped to `MAX_OPEN_CONNS`.
- `CONN_MAX_LIFETIME` **0 or 3s**: Sets the maximum amount of time a DB connection may be reused - default is 0, meaning there is no limit (except on MySQL where it is 3s - see #6804 & #7071). Please see #8540 & #8273 for further discussion of these values regarding port exhaustion.

## Indexer (`indexer`)

Expand Down