-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Localize time units on activity heatmap #21570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
0479791
Localize time units on activity heatmap
yardenshoham 9bbba06
Localize heatmap constants and tooltip
yardenshoham 5cadb9d
Merge remote-tracking branch 'upstream/main' into localize-heatmap
yardenshoham 57e4135
Add tests
yardenshoham 2d01191
Destructure
yardenshoham 95dd077
Merge remote-tracking branch 'upstream/main' into localize-heatmap
yardenshoham eba5ff3
Drop line
yardenshoham 50092fc
Merge branch 'main' into localize-heatmap
yardenshoham d1a8a92
Rename `format` --> `translate`
yardenshoham fa30c07
Remove overhead
yardenshoham 9e07322
Merge remote-tracking branch 'upstream/main' into localize-heatmap
yardenshoham d2d5081
Update web_src/js/utils.js
yardenshoham afaa731
Update web_src/js/utils.test.js
yardenshoham d44a422
Revert locale attempt
yardenshoham e54d70d
Merge branch 'main' into localize-heatmap
yardenshoham 55b2f28
Lint
yardenshoham 8775a5a
Merge remote-tracking branch 'upstream/main' into localize-heatmap
yardenshoham 2557f99
Merge branch 'main' into localize-heatmap
lunny 51f400f
Merge branch 'main' into localize-heatmap
lunny caaee20
Trigger build
yardenshoham 607473b
Merge branch 'main' into localize-heatmap
lunny a7a75d2
Merge branch 'main' into localize-heatmap
lunny 1a4fe52
Merge branch 'main' into localize-heatmap
lunny 2b416cc
Merge branch 'main' into localize-heatmap
yardenshoham 6cd227c
Merge branch 'main' into localize-heatmap
techknowlogick File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
const {lang} = document.documentElement; | ||
|
||
// given a month (0-11), returns it in the documents language | ||
const formatMonth = (month) => new Date(Date.UTC(2022, month, 12)).toLocaleString(lang, {month: 'short'}); | ||
|
||
// given a weekday (0-6, Sunday to Saturday), returns it in the documents language | ||
const formatDay = (day) => new Date(Date.UTC(2022, 7, day)).toLocaleString(lang, {weekday: 'short'}); | ||
|
||
const months = new Array(12).fill().map((_, idx) => formatMonth(idx)); | ||
const days = new Array(7).fill().map((_, idx) => formatDay(idx)); | ||
|
||
const heatmapLocale = {months, days}; | ||
|
||
export default heatmapLocale; | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.