Skip to content

Move backend lint before frontend #18805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

lunny
Copy link
Member

@lunny lunny commented Feb 18, 2022

Let's see if CI is right now.

@silverwind
Copy link
Member

silverwind commented Feb 18, 2022

I don't this will work. The DAG that Drone will create will still parallelize the frontend/backend steps and I think this is what we want to have fast CI runs.

Also keep note that there are actually three backend lint steps. I think we should instead try a proper solution that excludes node_modules from golangci-lint. It's not a big issue, the failures are only intermittent.

Edit: Related to: #18803

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 18, 2022
@silverwind
Copy link
Member

Shall we close? I don't think this is the right approach and the CI failure is rare indeed.

@lunny lunny closed this Feb 26, 2022
@lunny lunny deleted the lunny/lint_seq branch February 26, 2022 10:14
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants