default_delete_branch_after_merge doesn't work

[sprnza]

Gitea Version

1.16.0

Git Version

2.30.2

Operating System

Debian 10

How are you running Gitea?

Gitea is running from docker container

Database

PostgreSQL

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Description

I've set default_delete_branch_after_merge to True using this:

http --auth user:pass PATCH https://try.gitea.io/api/v1/repos/user/TestRepo default_delete_branch_after_merge:=true

got this reply:

HTTP/1.1 200 OK

But when I create a PR a get checkbox "Delete branch 'test-branch' unchecked in UI and after merge the branch is not being deleted (so it's not just an UI issue).

Screenshots

No response

[noerw]

Looking at the code, I think you also need to set "has_pull_requests": true for changes to PR settings to have an effect:

gitea/routers/api/v1/repo/repo.go

Line 842 in 80c5967

if *opts.HasPullRequests && !unit_model.TypePullRequests.UnitGlobalDisabled() {

This doesn't seem like correct behavior to me, though changing this may be a breaking change to some.

[jolheiser]

Parent issue #13622