Skip to content

Enable Appveyor CI on Windows #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 9, 2016

Conversation

ankostis
Copy link
Contributor

@ankostis ankostis commented Oct 1, 2016

So that any changes are also tested on Windows.

@ankostis
Copy link
Contributor Author

ankostis commented Oct 1, 2016

@Byron I created the badge under your Appveyor account; please check it is correct and add smmap into your Appveyor projects,
Everyhthin passes OK!
[edit] I know the badge url is not the correct one.

@coveralls
Copy link

coveralls commented Oct 1, 2016

Coverage Status

Coverage remained the same at 93.227% when pulling 1597a88 on ankostis:appveyor into 65989da on gitpython-developers:master.

@coveralls
Copy link

coveralls commented Oct 1, 2016

Coverage Status

Coverage remained the same at 93.227% when pulling dfadc16 on ankostis:appveyor into 65989da on gitpython-developers:master.

@coveralls
Copy link

coveralls commented Oct 1, 2016

Coverage Status

Coverage decreased (-0.5%) to 92.736% when pulling be5d426 on ankostis:appveyor into 65989da on gitpython-developers:master.

@Byron Byron merged commit e282e18 into gitpython-developers:master Oct 9, 2016
@Byron
Copy link
Member

Byron commented Oct 9, 2016

Thanks so much ! I think for these changes to come through, I would have to re-publish this package, which I cannot do anymore as I have lost access to my old, google-based login. The same holds true for gitdb.
Is it possible to specify dependencies via github URLS in the setup.py ? Then I could possibly republish GitPython pointing to GitDB, and push GitDB pointing to smmap via a github URL.

@ankostis
Copy link
Contributor Author

ankostis commented Oct 9, 2016

Yes, it is possible to depend on Github[1][2], but it really worths the effort to have the packages in PyPi.
For development, there are other ways to force dependencies into local project folders instead of putting those projects as submodules.

[1] http://stackoverflow.com/questions/16584552/how-to-state-in-requirements-txt-a-direct-github-source
[2] http://stackoverflow.com/questions/32688688/how-to-write-setup-py-to-include-a-git-repo-as-a-dependency

@ankostis ankostis deleted the appveyor branch October 22, 2016 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants