Skip to content

Fix cloning to path with unicode #955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2019

Conversation

ulturt
Copy link
Contributor

@ulturt ulturt commented Oct 26, 2019

Fix cloning to directories with a path containing Unicode characters
Closes issue #920

Copy link
Member

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for improving yet another instance of GitPython's confused way of handling encodings.

For a moment I thought maybe it's generally helping if force_bytes would default its encoding keyword parameter to utf-8 instead of ascii, since ascii is a valid subset of utf-8, i.e. all ascii files are also utf-8 encoded files.

Then I was uncertain if it would actually end up working that way. Your advice is appreciated, maybe it's worth another PR if you think it should work.

@Byron Byron merged commit ebf4656 into gitpython-developers:master Oct 28, 2019
@Byron Byron added this to the v3.0.5 - Bugfixes milestone Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants