-
-
Notifications
You must be signed in to change notification settings - Fork 933
use git rev-parse to look for config file #894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use git rev-parse to look for config file #894
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like there is test breakage directly related to this commit.
Could you have a look?
Thanks a lot for the contribution - I would love to merge, but can't as long as there is test breakage. Maybe it's an easy fix. |
bfc5263
to
946caf6
Compare
I tried a work-around but i'm not sure of it, there is some circular dependency between the search got the .git directory in Repo and the initialization of the self.git command wrapper (the git command should be able to find the .git itself, but the late initialization has maybe some use). |
14e53bf
to
f45c70a
Compare
And it works (I don't know the problem with appveyor, I do not think it's related to my patch). |
f45c70a
to
7f12bd4
Compare
Codecov Report
@@ Coverage Diff @@
## master #894 +/- ##
==========================================
- Coverage 93.6% 93.57% -0.03%
==========================================
Files 59 59
Lines 9769 9787 +18
==========================================
+ Hits 9144 9158 +14
- Misses 625 629 +4
Continue to review full report at Codecov.
|
Thanks so much! I am glad you could find the time. |
It fixes config file finding when in a separate worktree.
If fixes the issue with worktree reported in #719 (comment)