-
-
Notifications
You must be signed in to change notification settings - Fork 933
Travis CI: 'sudo' tag is now deprecated in Travis #825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[Travis are now recommending removing the __sudo__ tag](https://blog.travis-ci.com/2018-11-19-required-linux-infrastructure-migration).
@@ -9,10 +9,8 @@ matrix: | |||
include: | |||
- python: 3.7 | |||
dist: xenial |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might be able to move dist: xenial
out one level and define it globally. If so, you can move the python declarations out to the global list and eliminate the matrix include section all together.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm that both solutions work. While xenial is generally available, it is not the Travis default distro so I usually take the more conservative route of only using it where it is needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#831 eliminates one test when run on xenial so I think it is best to run more tests on Pythons that are compatible with the Travis CI default distro and fewer tests only on Python 3.7 and nightly.
Codecov Report
@@ Coverage Diff @@
## master #825 +/- ##
==========================================
- Coverage 94.79% 94.67% -0.12%
==========================================
Files 59 59
Lines 9600 9386 -214
==========================================
- Hits 9100 8886 -214
Misses 500 500
Continue to review full report at Codecov.
|
Travis are now recommending removing the sudo tag.