Commit without executing hooks, fixes #468 #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With the current code-base, it would be a bit cumbersome to test, as you would probably have to check that an actual hook as not been called. Mocking injection seems difficult without a little refactoring. So I guess merging it will just be fine in this case, thanks for your contribution ! |
|
Awesome! That's going to really help me. |
|
A new release was just pushed to pypi. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a start to fix #468
However, I have no idea where to add tests for this.
I couldn't find any basic test that just tests the commit, with executing hooks. Tips most appreciated.