Make sure .read() and friends always return bytes

[nvie]

This had tripped me up when consuming from .read(4096) in a streaming fashion. All chunks will return bytes except the last one (the empty string), which is a unicode string in Python 3.

This fixes that to always return bytes, in both Python 2 and 3.

[Byron]

Thanks @nvie , much appreciated !
It seems it works well in python 2.x, but apparently the test itself has wrong expectations and thus fails in py3.x.
Do you think changing this line to assert s.readline() == b'' will do it ?

[nvie]

I've fixed the tests as you indicated. I had some trouble running the tests locally (I just tried running tox, but it failed on different tests, not this one). My local tests are still failing, not sure why. I'll await Travis' response now and adjust accordingly.

Thanks for this awesome project, @Byron!

[nvie]

Seems all good now :)

[Byron]

Thanks @nvie ! Testing locally usually fails when you are on a branch. Reason for this is that GitPython uses its own git repository for read-only testing, but doesn't really deal with the edge-cases arising from it. Bad practice, I know :).

Besides: I still remember when I was first studying this git-flow page that so neatly visualised the branching scheme that so many are using today ! Thus it's great to have your name in this project's commit history :) !

[nvie]

Thanks, that's great to hear. As the matter of fact, we're starting to use more and more of GitPython, and we're seeing some wild repositories, so expect more contributions in the future. First one is #408 :)