Skip to content

Fix missing stderr when the progress parameter of _clone is None #1224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 22, 2021

Conversation

liangjingyang
Copy link
Contributor

Try to fix #1221

The to_progress_instance function will convert None to RemoteProgress instance, so the line if progress_checked is True if progress parameter is None.

Copy link
Contributor

@muggenhor muggenhor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding this! I've created a unit test that fails without and succeeds with this change (also with only the the condition change as I suggested).

@Byron
Copy link
Member

Byron commented Apr 22, 2021

Thanks for finding this! I've created a unit test that fails without and succeeds with this change (also with only the the condition change as I suggested).

Are you able to push it into this PR? If not I would be happy to do that for you if you post it here.

@Byron
Copy link
Member

Byron commented Apr 22, 2021

Once approved by @muggenhor this one should be ready to merge. Looks good to me (as the tests are green :) even though without the fix they are not).

@Byron Byron merged commit b85fec1 into gitpython-developers:main Apr 22, 2021
@Byron Byron added this to the v3.1.16 - Bugfixes milestone Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

GitCommand missing stderr
3 participants