Skip to content

Treat warnings as errors when building documentation #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 13, 2020
Merged

Treat warnings as errors when building documentation #1035

merged 1 commit into from
Jul 13, 2020

Conversation

kiancross
Copy link
Contributor

This fixes all the current warnings when building the documentation and updates the Makefile to treat warnings as errors.

In reference to: #1033

@Byron Byron added this to the v3.1.8 - Bugfixes milestone Jul 13, 2020
@Byron
Copy link
Member

Byron commented Jul 13, 2020

You are on fire! Thanks so much!

With this fix there will be no silent breakage of the documentation anymore, and of course, it has gotten a little better as many of these warnings seem like actual errors or mistakes.

@Byron Byron merged commit 30387f1 into gitpython-developers:master Jul 13, 2020
@kiancross kiancross deleted the fix-documentation-warnings branch July 13, 2020 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants