-
-
Notifications
You must be signed in to change notification settings - Fork 934
PackingType of packed-Refs not understood: '# pack-refs with: peeled fully-peeled sorted' #687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
See pull request #689. i had the same problem after upgrading git. |
👋 We're hitting the same issue now that brew is upgrading our users' git to 2.15. Any way we could get a 2.1.8 release out with this patch? |
Same problem:
See full build log here: https://travis-ci.org/HariSekhon/pytools/builds/298554130#L6405 |
The fix has been merged to master, the next time a release is cut we should be all set. |
Can I request a release with this patch included please? Git 2.15 is the stable release as of Oct 30th. |
Is there an ETA on when you'll package a v2.1.8 release that includes this fix? |
Any news? Workaround - install unreleased version :) pip install -U git+http://github.com/gitpython-developers/GitPython.git |
Or install packaged version in your $distro which has patch :P |
See #704 about a new release. |
I am closing this issue in preparation for the next release, which contains the fix. I am sorry for having let you wait for so long! |
Rather than closing in preparation for the release, would you consider re-opening and then closing once the release is available? That way those of us who subscribe to notifications on this issue will be alerted to the availability of the new release. |
Thanks @Byron ! I appreciate it :) |
@truthdoug I totally agree, and fortunately the waiting is over now: https://pypi.python.org/pypi/GitPython |
Fix #65. GitPython 2.18 is now out with the required fix. gitpython-developers/GitPython#687 (comment)
I hit this issue and have limited control of getting the upgrade -- if anyone is in a similar situation you can workaround it by calling repo.git.tag(). |
@pmb311 I believe you can always monkey-patch the code, based on the fix that has been released by now. Do you think that will work? |
python3-git in Stretch is 2.1.1 which does not work with git 2.15+ leading to build failing with: PackingType of packed-Refs not understood: '# pack-refs with: peeled fully-peeled sorted' gitpython-developers/GitPython#687 The fix is to use GitPython 2.1.8 or later which is listed as requirement in Quibble. Thus let the virtualenv install the proper version. Buster is not affected since python3-git is 2.1.11. Bug: T256844 Change-Id: I073108049efc29b0fa1cbf7458d3ff9be3cb9aae
I guess the "sorted" token can be safely ignored;
_iter_packed_refs()
could probably be somewhat improved by adding a whitelist of supported tokens, the current code looks a bit fragile (but then, I don't know what the syntax and semantics for the packed-refs header is).The text was updated successfully, but these errors were encountered: