Skip to content

Assertion fails if git isn't in english #153

New issue
New issue
Closed
Closed
Assertion fails if git isn't in english#153
Milestone
 
v0.3.2
@jmcs

Description

@jmcs
jmcs
opened on Apr 14, 2014

When doing repo.remotes.origin.pull() I was getting an AssertionError in _get_fetch_info_from_stderr.

After some troubleshooting I found this was caused because you are only excluding lines starting with "from" in https://github.com/gitpython-developers/GitPython/blob/0.3/git/remote.py#L523 which doesn't apply for non English locales.

Activity

hashar

hashar commented on Jul 25, 2014

@hashar
hashar
on Jul 25, 2014
Contributor

I guess any call to the git executable should be made with LC_MESSAGES="C" environment variable.

hashar
added a commit that references this issue on Jul 25, 2014

Ensure consistent output from git command

3eb7265
hashar
mentioned this on Jul 25, 2014
Byron
added this to the v0.3.2 milestone on Nov 19, 2014
Byron

Byron commented on Nov 19, 2014

@Byron
Byron
on Nov 19, 2014
Member

This issue was fixed in v0.3.2, as is available on pypi.

Byron
closed this as completedon Nov 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @Byron@hashar@jmcs

        Issue actions
          Assertion fails if git isn't in english · Issue #153 · gitpython-developers/GitPython