[ws-daemon-api] add pvc flag to DisposeWorkspaceRequest #9811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csweichel
reviewed
May 9, 2022
| @@ -121,6 +121,9 @@ message DisposeWorkspaceRequest { | |||
|
|
|||
| // backup_logs triggers the upload of terminal logs | |||
| bool backup_logs = 3; | |||
|
|
|||
| // persistent_volume_claim is enabled if workspace is using PVC | |||
| bool persistent_volume_claim = 4; | |||
There was a problem hiding this comment.
isn't the workspace marked as PVC workspace within ws-daemon already? IMHO we send that information during InitWorkspace already.
There was a problem hiding this comment.
You are 💯 right. Thank you for catching that. Closing this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a persistent volume claim flag to DisposeWorkspaceRequest request that is used by #9475
Related Issue(s)
Fixes #
How to test
Release Notes
Documentation