Skip to content

Add labels to the E2E tests #9577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Add labels to the E2E tests #9577

wants to merge 4 commits into from

Conversation

jenting
Copy link
Contributor

@jenting jenting commented Apr 27, 2022

Description

Add labels to the E2E tests, the idea/concept of labels is

  • Add team label to the E2E tests to indicate the test belongs to which team, either IDE, workspace, etc. Therefore, we could run the label filter by each team without having to enter each test folder.
  • Add a component label to the E2E tests to indicate the test belongs to which Gitpod component (if possible).

Related Issue(s)

#8799

How to test

# It should only run the E2E tests with the label `team=workspace`, i.e., the E2E tests belong to the workspace team.
go test -v ./... \
  -kubeconfig=/home/gitpod/.kube/config \ 
  -namespace=<namespace> \
  -labels "team=workspace" 

# It should only run the E2E tests with the label `team=IDE`, i.e., the E2E tests belong to the IDE team.
go test -v ./... \
  -kubeconfig=/home/gitpod/.kube/config \ 
  -namespace=<namespace> \
  -labels "team=IDE" 

Release Notes

None

Documentation

No

@jenting
Copy link
Contributor Author

jenting commented Apr 27, 2022

After discussing with Kyle, this one is no more needed.
Close it.

@jenting jenting closed this Apr 27, 2022
@jenting jenting deleted the restructure branch April 27, 2022 13:57
@kylos101
Copy link
Contributor

Thanks, @jenting ! There might be a need for this in the future? So I appreciate the effort you put into this PR. For now, the thought is, we can run tests associated with component binaries, as the workspace team owns certain components.

If we run into an issue where a component has shared tests (tests for 2 or more teams), then we may want to consider labels? Alternatively, that would also be a good opportunity to suggest moving the test to a separate path, so it does not share with workspace binaries. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants