[server] infer extensions and add a comment #7392

svenefftinge · 2021-12-30T16:08:21Z

This commit adds vscode extensions to the inferred .gitpod.yml and adds a comment to the top, that links to the documentation.

follow up to: #7383

How to test

Start workspaces on repositories without .gitpod.yml and check the generated .gitpod.yml.

Release Notes

Also propose vscode extensions for yet unconfigured repositories.

svenefftinge · 2022-01-02T11:53:48Z

/werft run

👎 cannot start job - please talk to whoever's in charge of your Werft installation

aledbf · 2022-01-02T12:28:44Z

/werft run

👍 started the job as gitpod-build-se-more-inference.2

jankeromnes

Many thanks!

Code looks good to me at first glance. 👍

/approve

I wanted to test this, but couldn't start a workspace:

Maybe an unstable deployment?

Re-triggering just in case:

/werft run

components/server/src/config/config-inferrer.ts

components/server/src/config/configuration-service.ts

jankeromnes · 2022-01-03T11:03:04Z

/approve no-issue

/werft run

👍 started the job as gitpod-build-se-more-inference.3

roboquat · 2022-01-03T11:03:10Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jankeromnes

Associated issue requirement bypassed by: jankeromnes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~components/server/OWNERS~~ [jankeromnes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

akosyakov · 2022-01-03T11:44:50Z

components/server/src/config/config-inferrer.ts

@@ -36,6 +37,11 @@ export class ConfigInferrer {
        return ctx.config;
    }

+    protected async checkYaml(ctx: Context): Promise<void> {
+        // always add the YAML extension to support .gitpod.yml editing
+        this.addExtension(ctx, 'redhat.vscode-yaml');


We already always install it in VS Code, i.e. it is built-in extension.

Removed it 🙏

akosyakov · 2022-01-03T11:45:55Z

@svenefftinge You should look at product.json of VS Code in your machine for inspiration of hints based on repo content.

svenefftinge · 2022-01-04T10:26:45Z

@svenefftinge You should look at product.json of VS Code in your machine for inspiration of hints based on repo content.

Thanks, it's not the main intention to of this PR to have a complete list, but rather make a few non-controversial suggestions. Should definitely be further improved over time.

This commit adds vcode extensions to the inferred .gitpod.yml and adds a comment to the top, that links to the documentation.

jankeromnes

Looks good to me and works like a charm! 🧙

I see a few more potential small improvements, but these can definitely be done as follow-ups, so unblocking this outstanding PR. 🚀

jankeromnes · 2022-01-04T14:37:09Z

components/server/src/config/configuration-service.ts

+        return `# This configuration file was automatically generated by Gitpod.
+# Please adjust to your needs (see https://www.gitpod.io/docs/config-gitpod-file)
+# and commit this file to your remote git repository to share the goodness with others.


I'm not sure about the phrasing "to share the goodness with others", but I don't have a better proposal right now.

@gtsiolis Would you have any suggestions to improve this comment? (It's added to every auto-generated .gitpod.yml when you open a Gitpod workspace for any repository that doesn't already have one.)

Note: Let's not block this PR, but work on a better comment in a follow-up PR.

jankeromnes · 2022-01-04T14:37:35Z

components/server/src/config/configuration-service.ts

+${configString}
+`;


No need to add a second empty line at the bottom of the file (can also be fixed in a follow-up):

Suggested change

${configString}

`;

${configString}`;

roboquat · 2022-01-04T14:40:07Z

LGTM label has been added.

Git tree hash: 38c422ae7e3d40a90361bf013b266762d55d97c9

roboquat added do-not-merge/release-note-label-needed team: webapp Issue belongs to the WebApp team size/L release-note and removed do-not-merge/release-note-label-needed labels Dec 30, 2021

svenefftinge requested a review from jankeromnes January 2, 2022 11:53

jankeromnes reviewed Jan 3, 2022

View reviewed changes

components/server/src/config/config-inferrer.ts Show resolved Hide resolved

components/server/src/config/configuration-service.ts Outdated Show resolved Hide resolved

components/server/src/config/configuration-service.ts Show resolved Hide resolved

roboquat added the approved label Jan 3, 2022

akosyakov reviewed Jan 3, 2022

View reviewed changes

svenefftinge force-pushed the se/more-inference branch from 1adb280 to 9fb5eee Compare January 4, 2022 10:23

[server] infer extensions and add a comment

5feca43

This commit adds vcode extensions to the inferred .gitpod.yml and adds a comment to the top, that links to the documentation.

svenefftinge force-pushed the se/more-inference branch from 9fb5eee to 5feca43 Compare January 4, 2022 10:35

jankeromnes approved these changes Jan 4, 2022

View reviewed changes

roboquat assigned jankeromnes Jan 4, 2022

roboquat added the lgtm label Jan 4, 2022

roboquat merged commit 46d55a7 into main Jan 4, 2022

roboquat deleted the se/more-inference branch January 4, 2022 14:40

roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Jan 6, 2022

JanKoehnlein mentioned this pull request Jan 17, 2022

Epic: Re-use existing project scripts (Makefile, CI, Dockerfile) #7627

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[server] infer extensions and add a comment #7392

[server] infer extensions and add a comment #7392

Uh oh!

svenefftinge commented Dec 30, 2021 •

edited

Loading

Uh oh!

svenefftinge commented Jan 2, 2022 •

edited by werft-gitpod-dev-com bot

Loading

Uh oh!

aledbf commented Jan 2, 2022 •

edited by werft-gitpod-dev-com bot

Loading

Uh oh!

jankeromnes left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jankeromnes commented Jan 3, 2022 •

edited by werft-gitpod-dev-com bot

Loading

Uh oh!

roboquat commented Jan 3, 2022

Uh oh!

akosyakov Jan 3, 2022 •

edited

Loading

Uh oh!

svenefftinge Jan 4, 2022

Uh oh!

akosyakov commented Jan 3, 2022

Uh oh!

svenefftinge commented Jan 4, 2022

Uh oh!

jankeromnes left a comment

Uh oh!

jankeromnes Jan 4, 2022

Uh oh!

jankeromnes Jan 4, 2022

Uh oh!

roboquat commented Jan 4, 2022

Uh oh!

Uh oh!

[server] infer extensions and add a comment #7392

[server] infer extensions and add a comment #7392

Uh oh!

Conversation

svenefftinge commented Dec 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to test

Release Notes

Uh oh!

svenefftinge commented Jan 2, 2022 • edited by werft-gitpod-dev-com bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aledbf commented Jan 2, 2022 • edited by werft-gitpod-dev-com bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jankeromnes left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jankeromnes commented Jan 3, 2022 • edited by werft-gitpod-dev-com bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

roboquat commented Jan 3, 2022

Uh oh!

akosyakov Jan 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

svenefftinge Jan 4, 2022

Choose a reason for hiding this comment

Uh oh!

akosyakov commented Jan 3, 2022

Uh oh!

svenefftinge commented Jan 4, 2022

Uh oh!

jankeromnes left a comment

Choose a reason for hiding this comment

Uh oh!

jankeromnes Jan 4, 2022

Choose a reason for hiding this comment

Uh oh!

jankeromnes Jan 4, 2022

Choose a reason for hiding this comment

Uh oh!

roboquat commented Jan 4, 2022

Uh oh!

Uh oh!

svenefftinge commented Dec 30, 2021 •

edited

Loading

svenefftinge commented Jan 2, 2022 •

edited by werft-gitpod-dev-com bot

Loading

aledbf commented Jan 2, 2022 •

edited by werft-gitpod-dev-com bot

Loading

jankeromnes commented Jan 3, 2022 •

edited by werft-gitpod-dev-com bot

Loading

akosyakov Jan 3, 2022 •

edited

Loading