Skip to content

[scrubber] Scrub URLs in log messages #20843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2025
Merged

[scrubber] Scrub URLs in log messages #20843

merged 1 commit into from
Jun 2, 2025

Conversation

corneliusludmann
Copy link
Contributor

@corneliusludmann corneliusludmann commented May 26, 2025

Description

This PR scrubs URLs in log messages to fix CLC-1018.

Related Issue(s)

Fixes https://linear.app/gitpod/issue/CLC-1018/scrubbing-cloneurl-in-telemetry-data

How to test

Tested it with running the new test cases.

How can we test it end to end?

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, so rubber-stamp ✔️

As you mentioned, we should double check the output + do a quick smoke test 👍

@roboquat roboquat merged commit f1dc3a5 into main Jun 2, 2025
75 of 77 checks passed
@roboquat roboquat deleted the clu/scrub-urls branch June 2, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants