Skip to content

[ws-manager-mk2] Check empty ns, delete secrets before finalizer #16900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

WVerlaek
Copy link
Member

Description

Small fixes/improvements:

  • Show workspace type by default in kubectl get ws
  • Only remove finalizer once secrets deletion succeeded
  • Check for empty namespaces in config on startup

Related Issue(s)

Part of #11416

How to test

Release Notes

NONE

Documentation

Build Options:

  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-ee-license
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@WVerlaek WVerlaek self-assigned this Mar 17, 2023
@WVerlaek WVerlaek requested a review from a team March 17, 2023 13:54
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Mar 17, 2023
@roboquat roboquat merged commit 3a561bf into main Mar 20, 2023
@roboquat roboquat deleted the wv/mk2-check-empty-ns branch March 20, 2023 10:32
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/S team: workspace Issue belongs to the Workspace team
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants