Skip to content

[ws-manager-mk2] Add metrics #16109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 30, 2023
Merged

[ws-manager-mk2] Add metrics #16109

merged 6 commits into from
Jan 30, 2023

Conversation

Furisto
Copy link
Member

@Furisto Furisto commented Jan 30, 2023

Description

Add metrics to ws-manager-mk2

Related Issue(s)

Related to #11416

How to test

  • Start workspace
  • kubectl port-forward deploment/ws-manager-mk2 9500
  • curl -XGET localhost:9500/metrics

Release Notes

None

Documentation

Build Options:

  • /werft with-github-actions
    Experimental feature to run the build with GitHub Actions (and not in Werft).
  • leeway-no-cache
    leeway-target=components:all
  • /werft no-test
    Run Leeway with --dont-test

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-fo-mk2-metrics.19 because the annotations in the pull request description changed
(with .werft/ from main)

@Furisto Furisto self-assigned this Jan 30, 2023
@Furisto Furisto added feature: ws-manager-mk2 team: workspace Issue belongs to the Workspace team labels Jan 30, 2023
@Furisto Furisto marked this pull request as ready for review January 30, 2023 17:57
@Furisto Furisto requested a review from a team January 30, 2023 17:57
@@ -266,6 +277,10 @@ func (wsc *WorkspaceController) handleWorkspaceStop(ctx context.Context, ws *wor
return wsc.Status().Update(ctx, ws)
})

if err != nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why only if err!=nil?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be err == nil

@roboquat roboquat merged commit 382bde1 into main Jan 30, 2023
@roboquat roboquat deleted the fo/mk2-metrics branch January 30, 2023 22:22
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production feature: ws-manager-mk2 release-note-none size/XXL team: workspace Issue belongs to the Workspace team
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants