Skip to content

ws-manager: remove PVC once the workspace pod is unschedulable #14068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2022

Conversation

jenting
Copy link
Contributor

@jenting jenting commented Oct 21, 2022

Description

Remove PVC once the workspace pod is unschedulable.

Related Issue(s)

Fixes #13282

How to test

Case 1.

  • Create 100 pods to reach the per-node max pod limit
    for i in {1..100}; do kubectl run test-${i} --image ubuntu -- sleep 3600; done
  • Enable PVC feature flag.
  • Create a workspace, and make sure the workspace pod fails to up.
    • Waits for 10 minutes: the workspace pod finalizer is removed, and the PVC object is gone.
    • Waits for 30 minutes: the workspace pod is deleted.

Release Notes

None

Documentation

None

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-integration-tests=workspace
    Valid options are all, workspace, webapp, ide

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-jenting-13282.12 because the annotations in the pull request description changed
(with .werft/ from main)

@jenting jenting changed the title ws-manager: remove annotation gitpod/failedBeforeStopping ws-manager: remove PVC once the workspace stopped Oct 25, 2022
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-jenting-13282.16 because the annotations in the pull request description changed
(with .werft/ from main)

@jenting
Copy link
Contributor Author

jenting commented Oct 31, 2022

/werft run

👍 started the job as gitpod-build-jenting-13282.18
(with .werft/ from main)

@jenting
Copy link
Contributor Author

jenting commented Oct 31, 2022

/werft run

👍 started the job as gitpod-build-jenting-13282.19
(with .werft/ from main)

@jenting jenting force-pushed the jenting/13282 branch 2 times, most recently from cc3fd54 to 9c4b8a4 Compare November 1, 2022 05:15
@roboquat roboquat added size/XS and removed size/M labels Nov 1, 2022
@jenting jenting force-pushed the jenting/13282 branch 2 times, most recently from 795e462 to 60710ed Compare November 1, 2022 06:16
@roboquat roboquat added size/S and removed size/XS labels Nov 1, 2022
@jenting jenting changed the title ws-manager: remove PVC once the workspace stopped ws-manager: remove PVC once the workspace pod is unschedulable Nov 1, 2022
@jenting jenting marked this pull request as ready for review November 1, 2022 06:17
@jenting jenting requested a review from a team November 1, 2022 06:17
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Nov 1, 2022
@jenting
Copy link
Contributor Author

jenting commented Nov 1, 2022

/werft run recreate-vm=true

👍 started the job as gitpod-build-jenting-13282.27
(with .werft/ from main)

@utam0k
Copy link
Contributor

utam0k commented Nov 1, 2022

/werft run with-integration-tests=workspace

👍 started the job as gitpod-build-jenting-13282.28
(with .werft/ from main)

@roboquat roboquat merged commit 6fd748c into main Nov 1, 2022
@roboquat roboquat deleted the jenting/13282 branch November 1, 2022 07:50
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/S team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PVC] orphan PVC left if the ws-manager unable to start workspace pod
3 participants