Skip to content

iPad: README.md preview doesn’t scroll #1703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rogfrich opened this issue Aug 14, 2020 · 19 comments
Closed

iPad: README.md preview doesn’t scroll #1703

rogfrich opened this issue Aug 14, 2020 · 19 comments
Labels
editor: theia type: bug Something isn't working

Comments

@rogfrich
Copy link

Describe the bug

I’m working on an iPad. When I open a particular workspace which has a README.md file, Theia opens a tab displaying a preview of the rendered Markdown file. This preview is too long to fit on the screen. Scrolling by dragging a finger up the screen on the tab does not scroll as expected. Instead, it appears to move a highlight to the left of each of the visible elements on the screen - a line, like the pipe symbol. You can see it in this screenshot. This line jumps between Markdown elements when I drag, either with one finger or two. I am unable to scroll to see elements which are off the page.

Steps to reproduce

  • Use GitPod on an iPad (see below for detailed specs). Browser is iPadOS Safari.
  • Open a repo in GitPod which has a README.md longer than can be displayed on an iPad screen
  • Attempt to scroll through the preview which opens with the new workspace.

Expected behaviour

I’d expect that the scroll gesture would scroll smoothly through the whole Markdown preview, like it would any other file.

Additional information

Workspace ID: https://e554f9fa-a47e-4cae-94a3-9c77fb9054d9.ws-eu01.gitpod.io/#/workspace/soduku2
IPad specs: iPad Pro 11 2018, iPadOS 13.6.
Issue happens in both landscape and portrait orientation.
Other files aren’t affected - other files, including the source README.md file, scroll smoothly as expected.

Example repository

Workspace ID: https://e554f9fa-a47e-4cae-94a3-9c77fb9054d9.ws-eu01.gitpod.io/#/workspace/soduku2

@rogfrich
Copy link
Author

Sorry, it was late last night when I posted this, and I missed out a potentially relevant bit of information: I've "installed" GitPod as a web app on my iPad's homepage and was running the site as a progressive web app, not a normal Safari page.

@corneliusludmann corneliusludmann added type: bug Something isn't working editor: theia labels Aug 18, 2020
@jankeromnes
Copy link
Contributor

Hi @rogfrich, thank you for reporting this issue. I was able to reproduce it on my iPad (most panels can be scrolled without issues, except the Markdown preview, or the Keyboard Shortcuts panel, which was already reported here: eclipse-theia/theia#7763).

I'll take a look at both issues and see if they can be fixed in Theia. Then, once a fix is merged into Theia, we could roll it out to Gitpod within a few weeks.

@rogfrich
Copy link
Author

Thanks @jankeromnes - Gitpod is the best solution I've found to doing proper development on the iPad, so it's great to hear this can be fixed. Thanks for all your efforts.

@C-alcium
Copy link

Just wanted to say, facing the same issue here. It's actually seriously irritating but it's super to see this has a fix in the pipe :) Looking forward to retiring my laptop in favour of using gitpod on my ipad.

@C-alcium
Copy link

Maybe this is related? coder/code-server#1455 (comment)

@C-alcium
Copy link

C-alcium commented Sep 9, 2020

is there any plan to fix this?

@jankeromnes
Copy link
Contributor

jankeromnes commented Sep 10, 2020

Hi @C-alcium, yes we're still planning to fix this as soon as possible. I've already looked into it, but unfortunately my first suspicion wasn't verified, and I haven't been able to successfully debug this yet.

If you have any insight in debugging no-scroll issues on iPad, please let me know. Otherwise I'll try again soon.

@jankeromnes
Copy link
Contributor

jankeromnes commented Sep 10, 2020

Also I think the Coder issue is about arrow keys and track pad, which have been fixed in WebKit and already work well in Gitpod/Theia.

This issue is about any scrolling at all, in Markdown previews and Keybinding settings.

@C-alcium
Copy link

If I am able to carve out some time I'll look at it, but no promises at this time of year

@Dids
Copy link

Dids commented Dec 16, 2020

Scrolling should be fixed in an upcoming iOS/iPadOS version, but no ETA on when yet. The WebKit part of the fix is already in though.

@C-alcium
Copy link

C-alcium commented Feb 16, 2021

I see this is fixed in code-server -- is it fixed in gitpod? If so, this issue can be closed

Edit: I just tested it and it is not fixed.

@Dids
Copy link

Dids commented Feb 16, 2021

I see this is fixed in code-server -- is it fixed in gitpod? If so, this issue can be closed

Edit: I just tested it and it is not fixed.

"Fixed" is a strong word. From my own experience (and of a handful of others), it only works if you install a website as a PWA through Safari. Outside of that it doesn't seem to work.

@C-alcium
Copy link

I see this is fixed in code-server -- is it fixed in gitpod? If so, this issue can be closed
Edit: I just tested it and it is not fixed.

"Fixed" is a strong word. From my own experience (and of a handful of others), it only works if you install a website as a PWA through Safari. Outside of that it doesn't seem to work.

That's really unfortunate

@stale
Copy link

stale bot commented May 18, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label May 18, 2021
@stale stale bot closed this as completed May 28, 2021
@jankeromnes
Copy link
Contributor

I don't think this issue is stale. We should keep it open until the problem is confirmed as fixed.

@jankeromnes jankeromnes reopened this May 28, 2021
@stale stale bot removed meta: stale This issue/PR is stale and will be closed soon labels May 28, 2021
@stale
Copy link

stale bot commented Aug 26, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Aug 26, 2021
@jankeromnes
Copy link
Contributor

@akosyakov @ghuntley do you know if Gitpod is still affected by this bug?

@stale stale bot removed the meta: stale This issue/PR is stale and will be closed soon label Aug 30, 2021
@akosyakov
Copy link
Member

@jankeromnes 🤷‍♂️

@ghuntley
Copy link
Contributor

Unable to reproduce on iPadOSb7. Closing it out. Please raise another issue if it manifests again.

PXL_20210831_031027910.LS.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor: theia type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

7 participants