-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Can’t scroll on iPad with a trackpad. #1455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Magic Mouse also doesn't "scroll" it seems to simulate "up" and "down" from the keyboard instead. There may be behavior settings we need to adjust? |
Also, the scroll wheel on a mouse scrolls the entire window instead of just the text editor area. |
On a Logitech MX Vertical, binding Scroll Up and Scroll Down in Assistive Touch settings to the forward and back buttons allows for scrolling in the terminal/code windows separately. I haven’t found a way to bind those actions to the gesture of scrolling on the Magic Trackpad 2 EDIT: Currently working around by highlighting then scrolling with one finger |
We're making this a priority. Thanks for the upvotes everyone, shows us it's in high demand 👀. |
@mjsamberg The app container scrolling should be fixed in the code-server 3.0 releases — certainly it appears to be better for me now in code-server 3.0.2. I can confirm though that neither the Magic Mouse 2 nor the Magic Trackpad 2 scrolling works in 3.0.2 though. Scrolling using the touchscreen does work, although it feels slow due to the fact that there is no scroll momentum. |
@neilalexander App container scrolling still occurs with my logitech mouse and the scroll wheel. |
Update on progress towards iPad trackpad/mouse support: After investigation, we've determined that this issue will require a significant patch to the VSCode scroll/touch handling logic and/or a patch to the WebKit events for iPad trackpad and mouse. VSCode handles all scrolling logic manually, nearly all scrollable elements have TLDR: We believe it's likely that WebKit will improve its handling of trackpad/mouse scrolling in the near future. When this happens, we will promptly add support. |
Thanks for the update, I had experienced weird behavior elsewhere so I assumed it was doing something under the hood |
Another update Please reference this WebKit issue for progress towards a patch. |
Hello, has somebody found any other workaround for this? (even if it is buggy) I mean, other than using the scrollbars. code-server and an Ipad pro with magic keyboard (which includes trackpad) is awesome! |
I did notice, FWIW, that scrolling does work as expected in Google Docs website on iPad in multiple directions and even when there are multiple scrollable elements on the screen. |
@mjsamberg the faulty interaction between iPad trackpad and the code-server editor view seems to be an edge case. I see a lot of complex web apps handling scrolling stuff without any issue (gdocs, office356, dropbox, etc). The mentioned WebKit issue linked by @cmoog also has no movement at all so far. |
@perelin VS Code's editor handles scrolling manually so that it doesn't have to load the entire file into memory all at once. The ability to control scrolling manually is what's unsupported by webkit on iOS. |
Curious, has anyone played around with this on iOS 14 beta yet and noticed a difference? |
@danielscottjames Just tried it, no difference. |
Oh, that is heartbreaking @mjsamberg. I was hoping it would work. |
I hope any improvement of this case. |
Don’t we all... |
Same here 😔 |
I can also report this issue, scrolling on the magic keyboard for iPad just scrolls the entire browser window and not the editor pane |
Hooray!, I can confirm that the scrolling issue is fixed on the latest iPadOS 14.5 dev beta 1. Welcome to true coding on iPad fellas. Super happy 😃 🔥 🚀 RPReplay_Final1612209678.2.mov |
Yup. Can confirm - works fine on 14.5 :) Now I can finally replace my laptop for on the go sessions! |
Does this require a new version of code-server? Updated my iPad Air 2020 to 14.5, but still can't scroll with my Magic Keyboard. Clicking now works consistently though. |
No. This was not a bug at code-Server (or vs-code to be precise) but safari. |
I had the same problem, but scrolling works if you add the site to the home screen and open as a PWA. |
Can confirm it works in the PWA but not working in a tab in safari. Also @Dids I don’t have any settings for Settings -> Safari |
Works fine for me in a browser tab as well. |
Works for me as PWA. While in browser, scroll works only when the URL bar is hidden. It doesn't matter whether the "Wheel" settings are on or off. |
I can confirm that scrolling with a Magic Keyboard + latest iPad Air (iPadOS 14.5 b2) only works when a) using PWA or b) specifically hiding the address bar in Safari. Does anyone actually know why this happens and are some of the reports here truly saying it "just works" for them in Safari, while the address bar is visible and not running as a PWA? I've even tried rolling my own web view wrapper apps, enabling app domains for increased API support, but nothing seems to work outside of the two solutions above. As it currently is, this seems very janky and hacky, but at this point I can't even tell if this is intended behavior or something the WebKit or iOS/iPadOS developers should fix? |
Me too. Only works in PWA of safari.
…________________________________
发件人: Pauli Jokela <[email protected]>
发送时间: 2021年2月22日 6:35
收件人: cdr/code-server <[email protected]>
抄送: 陈大羊 <[email protected]>; Comment <[email protected]>
主题: Re: [cdr/code-server] Can’t scroll on iPad with a trackpad. (#1455)
I can confirm that scrolling with a Magic Keyboard + latest iPad Air only works when a) using PWA or b) specifically hiding the address bar in Safari.
Does anyone actually know why this happens and are some of the reports here truly saying it "just works" for them in Safari, while the address bar is visible and not running as a PWA?
I've even tried rolling my own web view wrapper apps, enabling app domains for increased API support, but nothing seems to work outside of the two solutions above. As it currently is, this seems very janky and hacky, but at this point I can't even tell if this is intended behavior or something the WebKit or iOS/iPadOS developers should fix?
―
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#1455 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADWWO45UFXCJD644U32ELLLTAH3JVANCNFSM4LTV6O3A>.
|
Ever imagined, that there are people where „it just works“? Since the first developer beta of 14.5 Maybe its an iPad Air issue. Works fine for anyone using an iPad Pro here… Edit: and this is still not an issue of code-server but an Safari bug. |
I am having the issue that cannot scroll in browser tab with address bar shown on my iPad Pro 12.9''. Since the first beta of 14.5 and the latest version of code-server. :( Seems not a issue only on ipad air. |
I can confirm that issue will be solved with iPadOS 14.5. I’m using an iPad Air (4th generation). |
Works on 14.5 now using PWA/Adding to home screen. |
For me it works on iPadOS 14.5 (2018 iPad Pro 11”) both in Safari and in PWA. 🎉 Menu / Help / About: EDIT: |
Confirmed as well. Working on iPadOS 14.5 when you add code-server to your home screen/PWA. Tested with code-server 3.9.3 ScreenshotRPReplay_Final1619643901.MP4Given that iPadOS 14.5 was released to the public on April 26 (see release notes) and we know this is working, I'm going to close this. |
On an iPad running iPadOS 13.4 (which added full trackpad/mouse support), two-finger-scrolling on a trackpad doesn’t work (nothing happens).
Tested in different panels (editor, terminal, settings).
Tested using Magic Trackpad 2 (Apple’s iPad Pro keyboard with trackpad is not yet available).
Tried both the :latest (About window shows 1.41.1) and :3.0.1 docker images.
The text was updated successfully, but these errors were encountered: