test: Automatic detection of whether PVC is operational or not

[utam0k]

Is your feature request related to a problem? Please describe

The self-hosted test is not an environment in which PVC can operate. Currently, we have to change the code to make the test work.
We can reduce this friction by detecting if the PVC test can run and skipping the test if necessary.

Describe the behaviour you'd like

Pass the test on an env without PVC env

Describe alternatives you've considered

Additional context

[kylos101]

@utam0k how would you recommend we do? For example, one option might be to change the configmap which stores the installer settings used to install Gitpod. If PVC is enabled there, then proceed with testing PVC. Can you think of any other ideas?

cc: @sagor999 @jenting

[utam0k]

That's one way to go. Sorry but I don't have any specific ideas at the moment. I'd like to here @sagor999 and @jenting options.

[jenting]

Not sure if it's doable or not.

We could check the CSI driver contains the CREATE_DELETE_SNAPSHOT capability to determine whether we should test PVC or not.

[jenting]

Or, we could check the ws-manager ConfigMap, snapshotClass is empty string to determine whether we should test PVC or not.

[utam0k]

Or, we could check the ws-manager ConfigMap, snapshotClass is empty string to determine whether we should test PVC or not.

@kylos101 @jenting
I would recommend relying on our product rather than relying on Kubernetes because I think it is easier to control and understand mechanism.

[kylos101]

Rely on product how @utam0k ? Do you mean like a Gitpod config map, which contains installer options used to do the last install or upgrade?

[utam0k]

We could check the CSI driver contains the CREATE_DELETE_SNAPSHOT capability to determine whether we should test PVC or not.

Oh no, I was trying to figure out which of the two methods JenTing suggested would be easier for us to do. Presumably, the capability of the above method is a value that is managed by Kubernetes, right? Well, I think both methods are very good.

[utam0k]

So, I recommend this one

Or, we could check the ws-manager ConfigMap, snapshotClass is empty string to determine whether we should test PVC or not.

[jenting]

@utam0k
Could you please help to check the ws-manager ConfigMap snapshotClass is empty in the self-hosted installation?

[utam0k]

@jenting It looks like snapshotClass is always ""

[jenting]

@jenting It looks like snapshotClass is always ""

Thank you 🙏

[jenting]

The PVC integration test is disabled #14838. This issue is no longer valid.