Skip to content

C++: Use-use flow in experimental #10366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 13, 2022
Merged

C++: Use-use flow in experimental #10366

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6d313ac
C++: Copy the new use-use flow code to experimental.
MathiasVP Sep 9, 2022
5509562
C++: Repair a few broken models that were incorrectly a pointer
MathiasVP Aug 26, 2022
6dcfe03
C++: Copy over the required changes to non-experimental libraries.
MathiasVP Sep 9, 2022
c988547
C++: Accept test changes.
MathiasVP Sep 11, 2022
bb1c088
C++: Undo changes to iterator models.
MathiasVP Sep 12, 2022
d2b150e
C++: Fix QLDoc on the model predicates used by the new experimental u…
MathiasVP Sep 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cpp/ql/lib/semmle/code/cpp/models/implementations/Iterator.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ private class IteratorCrementMemberOperator extends MemberFunction, DataFlowFunc
output.isQualifierObject()
or
input.isQualifierObject() and
output.isReturnValueDeref()
output.isReturnValue()
}

override predicate hasTaintFlow(FunctionInput input, FunctionOutput output) {
Expand Down
2 changes: 1 addition & 1 deletion cpp/ql/lib/semmle/code/cpp/models/implementations/StdContainer.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ private class StdSequenceContainerInsert extends TaintFunction {
) and
(
output.isQualifierObject() or
output.isReturnValueDeref()
output.isReturnValue()
)
}
}
Expand Down
6 changes: 3 additions & 3 deletions cpp/ql/lib/semmle/code/cpp/models/implementations/StdString.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ private class StdStringAppend extends TaintFunction {
) and
(
output.isQualifierObject() or
output.isReturnValueDeref()
output.isReturnValue()
)
or
// reverse flow from returned reference to the qualifier (for writes to
Expand Down Expand Up @@ -543,11 +543,11 @@ private class StdOStreamOutNonMember extends DataFlowFunction, TaintFunction {

override predicate hasTaintFlow(FunctionInput input, FunctionOutput output) {
// flow from second parameter to first parameter
input.isParameter(1) and
input.isParameterDeref(1) and
output.isParameterDeref(0)
or
// flow from second parameter to return value
input.isParameter(1) and
input.isParameterDeref(1) and
output.isReturnValueDeref()
or
// reverse flow from returned reference to the first parameter
Expand Down
2 changes: 1 addition & 1 deletion cpp/ql/lib/semmle/code/cpp/models/implementations/Strcat.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ class StrcatFunction extends TaintFunction, DataFlowFunction, ArrayFunction, Sid
input.isParameterDeref(0) and
output.isParameterDeref(0)
or
input.isParameter(1) and
input.isParameterDeref(1) and
output.isParameterDeref(0)
}

Expand Down