Skip to content

fix: not try to tag spot requests when on-demand is set #4562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 23, 2025
Merged

fix: not try to tag spot requests when on-demand is set #4562

merged 3 commits into from
Apr 23, 2025

Conversation

npalm
Copy link
Member

@npalm npalm commented Apr 22, 2025

fix #4561

@npalm npalm requested a review from a team as a code owner April 22, 2025 21:31
npalm
npalm commented Apr 23, 2025
View reviewed changes
Copy link
Member Author

@npalm npalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with both spot and not spot

@npalm npalm changed the title fix: only tag spot rquests for spot fix: not try to tag spot requests when on-demand is set Apr 23, 2025
@npalm npalm merged commit a9ab69e into main Apr 23, 2025
39 checks passed
@npalm npalm deleted the npalm/fix-spot-request-tagging branch April 23, 2025 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koendelaat koendelaat koendelaat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

spot-instances-request tags breaks on-demand instances
2 participants
@npalm @koendelaat