docs: Change root to Top Level Directory #4174
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartp44
changed the title
npalm
requested changes
Oct 8, 2024
| @@ -1,4 +1,4 @@ | |||
| # Runner module (root) | |||
| # Runner module (Top Level Directory) | |||
There was a problem hiding this comment.
In terraform term we speaking about modules, the ones below the first level (parten / top-level / root) are called submodule. When would like to make it explict here, would prefer to keep it short (so it renders nice). Either parent or top-level.
Suggested change
| # Runner module (Top Level Directory) | |
| # Runner module (Top Level) |
There was a problem hiding this comment.
Please see PR for a suggestion https://github.com/philips-labs/terraform-aws-github-runner/pull/4175
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs: After seeing a few issues being opened regarding failed usage of modules, I think the language surrounding the menus is wrong or misleads a little. I have reworded this to hopefully help.