refactor: scale down tests #3997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npalm
commented
Jul 17, 2024
There was a problem hiding this comment.
export two functions for explicit testing
npalm
force-pushed
the
npalm/scale-down-test-refactor
branch
from
7481caa to
5eac458
Compare
stuartp44
approved these changes
Jul 17, 2024
lambdas/functions/control-plane/src/scale-runners/scale-down.test.ts
Outdated
Show resolved
Hide resolved
lambdas/functions/control-plane/src/scale-runners/scale-down.test.ts
Outdated
Show resolved
Hide resolved
stuartp44
requested changes
Jul 17, 2024
Co-authored-by: Stuart Pearson <[email protected]>
stuartp44
approved these changes
Jul 17, 2024
ScottGuymer
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test structure and magic for scaling down makes it hard to make any change. This PR refactor the tests cases in suche way
Test coverage is 100% for scale-down.
Note: Codescene warnings are not new, but a bit the fact of how jest works