Skip to content

fix: add warnings to log for GitHub rate limits #3988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Conversation

npalm
Copy link
Member

@npalm npalm commented Jul 15, 2024

Adding explicit logging for GitHub reate limits. No retries implemented. Only for abuse retrying seems an option. In other cases a retry will take to long given lambda timeouts taken into accont.

@npalm npalm merged commit 2ed0b29 into main Jul 17, 2024
4 checks passed
@npalm npalm deleted the npalm/rate-limit-warning branch July 17, 2024 09:02
npalm pushed a commit that referenced this pull request Aug 1, 2024
🤖 I have created a release *beep* *boop*
---


##
[5.13.0](philips-labs/terraform-aws-github-runner@v5.12.2...v5.13.0)
(2024-08-01)


### Features

* **webhook:** Enable authorizer assignment to webhook
([#4000](https://github.com/philips-labs/terraform-aws-github-runner/issues/4000))
([b78ccde](philips-labs/terraform-aws-github-runner@b78ccde))
@SSW-SCIENTIFIC


### Bug Fixes

* add warnings to log for GitHub rate limits
([#3988](https://github.com/philips-labs/terraform-aws-github-runner/issues/3988))
([2ed0b29](philips-labs/terraform-aws-github-runner@2ed0b29))
* bump node dependencies and cleanup
([#4020](https://github.com/philips-labs/terraform-aws-github-runner/issues/4020))
([221958b](philips-labs/terraform-aws-github-runner@221958b))
* **lambda:** bump the aws group across 1 directory with 5 updates
([#4005](https://github.com/philips-labs/terraform-aws-github-runner/issues/4005))
([4ca422d](philips-labs/terraform-aws-github-runner@4ca422d))
* **lambda:** bump the aws group across 1 directory with 5 updates
([#4017](https://github.com/philips-labs/terraform-aws-github-runner/issues/4017))
([0cd6a85](philips-labs/terraform-aws-github-runner@0cd6a85))
* mark github_app variable as sensitive
([#4013](https://github.com/philips-labs/terraform-aws-github-runner/issues/4013))
([08be669](philips-labs/terraform-aws-github-runner@08be669))
@jizi

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: forest-releaser[bot] <80285352+forest-releaser[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants