Skip to content

chore: Execute var.custom_shell_commands in a separate shell provisioner in Packer #3940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

espizo
Copy link

@espizo espizo commented Jun 18, 2024

This commit fixes #3939

This ensures that the ec2-user is seen as member of the docker group
when executing commands.
@npalm npalm self-requested a review June 27, 2024 12:32
Copy link
Member

@npalm npalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please can you check the CI job. The validation is failing with the error no script provided. It seems a default empy array is now allowed. Maybe adding a default with echo no custom script set could do the trick.

@stuartp44
Copy link
Contributor

@espizo nudge for you.

@stuartp44 stuartp44 marked this pull request as draft October 3, 2024 07:39
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Feb 15, 2025
@github-actions github-actions bot closed this Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ec2-user is not seen as a member of the docker group when var.custom_shell_commands is executed
3 participants