fix(lambda): repair repository allow list #3830
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that the environment variable was previously renamed from `REPOSITORY_WHITE_LIST` to `REPOSITORY_ALLOW_LIST`. However, this change was only applied in the `webhook` lambda, while Terraform continues to use the old name. This pull request corrects the repository allow list functionality without introducing any breaking changes. It's unclear how deprecation and breaking changes are typically handled, so this approach avoids any potential disruptions.
|
Any chance to review my pull request? |
|
I think the repo allow list was introduced in early days, before having runner groups. Do we still need the allow list. Could you explain the use case? Happy to got it fixed right now. But would prefer if we can remove it at all. |
|
@npalm I don't have any real usecase. Just tested this feature and found the bug :) In my case I set the webhook only for a single github repo. |
clear, but this means most likely the feature is not used at all anymore. Thanks for you contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the environment variable was previously renamed from
REPOSITORY_WHITE_LISTtoREPOSITORY_ALLOW_LIST. However, this change was only applied in thewebhooklambda, while Terraform continues to use the old name.This pull request corrects the repository allow list functionality without introducing any breaking changes. It's unclear how deprecation and breaking changes are typically handled, so this approach avoids any potential disruptions.