-
Notifications
You must be signed in to change notification settings - Fork 660
fix(lambda): bump the octokit group in /lambdas with 3 updates #3806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(lambda): bump the octokit group in /lambdas with 3 updates #3806
Conversation
Bumps the octokit group in /lambdas with 3 updates: [@octokit/auth-app](https://github.com/octokit/auth-app.js), [@octokit/types](https://github.com/octokit/types.ts) and [@octokit/webhooks](https://github.com/octokit/webhooks.js). Updates `@octokit/auth-app` from 6.0.3 to 6.0.4 - [Release notes](https://github.com/octokit/auth-app.js/releases) - [Commits](octokit/auth-app.js@v6.0.3...v6.0.4) Updates `@octokit/types` from 12.5.0 to 12.6.0 - [Release notes](https://github.com/octokit/types.ts/releases) - [Commits](octokit/types.ts@v12.5.0...v12.6.0) Updates `@octokit/webhooks` from 12.1.2 to 13.1.1 - [Release notes](https://github.com/octokit/webhooks.js/releases) - [Commits](octokit/webhooks.js@v12.1.2...v13.1.1) --- updated-dependencies: - dependency-name: "@octokit/auth-app" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: octokit - dependency-name: "@octokit/types" dependency-type: direct:production update-type: version-update:semver-minor dependency-group: octokit - dependency-name: "@octokit/webhooks" dependency-type: direct:production update-type: version-update:semver-major dependency-group: octokit ... Signed-off-by: dependabot[bot] <[email protected]>
THe update seems caused by a change in octokit/webhooks (from ESM to CJS). See https://github.com/octokit/webhooks.js/releases/tag/v13.0.0 @PatrickMennen @nadavsinai-philips any suggestion how we fix this? |
the import |
Previous the package webhook-types was a transitive one. But it seems the types Addiong webhook-types as dev dependencies result in the following error:
Seems this is related to the move from ESM to CJS, or not? |
Yes, this is related, move from CJS to ESM is like that, you’ll have to transpile that back to CJS if you don’t want to move all your stack to ESM
Jest let you transform code prior to running it - https://jestjs.io/docs/code-transformation
normally you transform your own code (from typescript or just modern JS) and add transformIgnorePatterns to ignore code from libs
but in this case – you’d want to negate that ignore so that the code transformation of something in the link of babel would transform that @octakit ESM module back to CJS
sorry that I’m out of time to look into the details of that and fix that myself but I hope I at least manage to give you the right direction
another option – don’t do the update to 13.x until you have the time for this…
|
Looks like these dependencies are updatable in another way, so this is no longer needed. |
Bumps the octokit group in /lambdas with 3 updates: @octokit/auth-app, @octokit/types and @octokit/webhooks.
Updates
@octokit/auth-app
from 6.0.3 to 6.0.4Release notes
Sourced from
@octokit/auth-app
's releases.Commits
61d61c2
fix(README): usage example (#579)fb0624e
maint: fix some spelling errors (#576)e167700
build(deps): lock file maintenance (#577)0c15ee7
build(deps): lock file maintenance (#574)c97c234
build(deps): lock file maintenancef063a5e
chore(deps): update dependency prettier to v3.2.5 (#572)94a8663
build(deps): lock file maintenance (#571)bddd8ab
chore(deps): update dependency esbuild to ^0.20.09733c31
ci(action): update peter-evans/create-or-update-comment action to v4151f063
chore(deps): update dependency prettier to v3.2.4 (#567)Updates
@octokit/types
from 12.5.0 to 12.6.0Release notes
Sourced from
@octokit/types
's releases.Commits
b2d7de9
feat: many new endpoints (#618)Updates
@octokit/webhooks
from 12.1.2 to 13.1.1Release notes
Sourced from
@octokit/webhooks
's releases.... (truncated)
Commits
6566aaf
fix(types): Adds repository-rule-params-thresholds, repository-rule.role_name...350e14d
build(deps): lock file maintenance (#984)e36b0f7
build(deps): lock file maintenance (#983)25db027
feat(types): addsplatform_chat
,cli
, renamescopilot_chat
>ide_chat
...56b10f6
build(deps): lock file maintenance (#981)31f4c6d
fix(types): description updates (#980)c3196ab
ci(action): update actions/add-to-project action to v0.6.07209e78
ci(workflows): updates and fixes (#975)bb573c8
fix(deps): update dependency@octokit/openapi-webhooks-types
to v6 (#978)bd224a1
feat: v13 (#967)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major version
will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor version
will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>
will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>
will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>
will remove the ignore condition of the specified dependency and ignore conditions