Output for syncer binary location is incorrect #4137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

driskell opened this issue Sep 17, 2024 · 1 comment · Fixed by #4274 or #4313

Labels

driskell commented Sep 17, 2024

https://github.com/philips-labs/terraform-aws-github-runner/blob/v5.10.4/outputs.tf#L28

It appears to have a variable that doesn't exist but it is also a literal not a variable. I think it is meaning:

location         = "s3://${module.runner_binaries[0].bucket.id}/${module.runner_binaries[0].runner_distribution_object_key}"

The text was updated successfully, but these errors were encountered:

Member

npalm commented Oct 2, 2024

Would you have time to make a fix?

stuartp44 added bug support labels

winwinashwin added a commit to winwinashwin/terraform-aws-github-runner that referenced this issue


          fix: Incorrect syncer binary location in tf outputs (github-aws-runne…

f3bc972

…rs#4137)

The output location for syncer binary was not declared correctly in tf
outputs.

Fixes: github-aws-runners#4137

winwinashwin mentioned this issue

fix: Incorrect syncer binary location in tf outputs #4274

Merged

npalm closed this as completed in #4274

npalm closed this as completed in

401a373

forest-releaser bot mentioned this issue

chore(main): release 5.21.0 #4313

Merged

npalm pushed a commit that referenced this issue


          chore(main): release 5.21.0 (#4313)

dd4591e

🤖 I have created a release *beep* *boop*
---


##
[5.21.0](philips-labs/terraform-aws-github-runner@v5.20.1...v5.21.0)
(2024-12-20)


### Features

* Natively support runner pre/post job hooks
([#4263](https://github.com/philips-labs/terraform-aws-github-runner/issues/4263))
([259a852](philips-labs/terraform-aws-github-runner@259a852))


### Bug Fixes

* Incorrect syncer binary location in tf outputs
([#4274](https://github.com/philips-labs/terraform-aws-github-runner/issues/4274))
([401a373](philips-labs/terraform-aws-github-runner@401a373)),
closes
[#4137](https://github.com/philips-labs/terraform-aws-github-runner/issues/4137)
* **lambda:** bump @octokit/types from 13.6.1 to 13.6.2 in /lambdas in
the octokit group
([#4303](https://github.com/philips-labs/terraform-aws-github-runner/issues/4303))
([9f76c4c](philips-labs/terraform-aws-github-runner@9f76c4c))
* **lambda:** bump axios from 1.7.7 to 1.7.9 in /lambdas
([#4305](https://github.com/philips-labs/terraform-aws-github-runner/issues/4305))
([e3cd5b4](philips-labs/terraform-aws-github-runner@e3cd5b4))
* **lambda:** bump the aws group across 1 directory with 7 updates
([#4314](https://github.com/philips-labs/terraform-aws-github-runner/issues/4314))
([3f9b768](philips-labs/terraform-aws-github-runner@3f9b768))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: forest-releaser[bot] <80285352+forest-releaser[bot]@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment