Added keep length parameter #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
PR Summary
|
|
@QuentiumYT This looks like a great PR. Thanks 👍 Just one issue, tests and builds are failing with: |
|
Yeah had some issues with yarn when installing the dependencies. Will try to fix it :) |
|
There were an issue about this version of vuepress (probably renamed or deleted from dependencies) and fixed it in the lockfile to force using the latest with correct vuepress-vite dependency version. ( |
|
Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I recently found this projet and it really does well the job!
For user interface purposes, I needed to keep the same number of items in the pagination. Currently, when we're at page 1, it shows 4 more items on the right (2, 3, ..., 20). Seems normal not having on the left but once it's set to 10 for example, we do have 4 more elements on the left (1, ..., 8, 9) which doubles almost the length.
Before:
After:
As you can see, "after" shows 11 elements all the time, and not only at the beginning and the end.
This prop is not set to true by default to prevent package updates compatibility but I find it interesting to have. (Also, I didn't added tests (not really good at it) but feel free to do so 😃)
Thanks for having a look at it!