SYN-1945 Support Snowflake TRIM. #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zdenal
commented
Sep 22, 2023
| @@ -1275,13 +1276,24 @@ impl<'a> Parser<'a> { | |||
| expr: Box::new(expr), | |||
| trim_where, | |||
| trim_what: Some(trim_what), | |||
| trim_characters: None, | |||
| }) | |||
| } else if self.consume_token(&Token::Comma) && dialect_of!(self is SnowflakeDialect) { | |||
There was a problem hiding this comment.
no FROM and Snowflake and next is Comma (by doc Snowflake doesn't support FROM syntax) -> parse characters
zdenal
commented
Sep 22, 2023
| Box::new(PostgreSqlDialect {}), | ||
| Box::new(MsSqlDialect {}), | ||
| Box::new(AnsiDialect {}), | ||
| //Box::new(SnowflakeDialect {}), |
There was a problem hiding this comment.
make sure it is still failing on others than snowflake.
zdenal
commented
Sep 22, 2023
| @@ -0,0 +1,36 @@ | |||
| name: Test Suite | |||
There was a problem hiding this comment.
Added simple test workflow to see on PRs results of tests.
zdenal
commented
Sep 22, 2023
| @@ -994,6 +997,9 @@ impl fmt::Display for Expr { | |||
| } else { | |||
| write!(f, "{expr}")?; | |||
| } | |||
| if let Some(characters) = trim_characters { | |||
| write!(f, ", {}", display_comma_separated(characters))?; | |||
| } | |||
There was a problem hiding this comment.
print trim characters after expression if there are
lustefaniak
approved these changes
Sep 22, 2023
zdenal
force-pushed
the
zdenko/snowflake-parse-trim-with-second-param-2
branch
from
c01f05c to
0398ed5
Compare
lustefaniak
deleted the
zdenko/snowflake-parse-trim-with-second-param-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We are getting errors with parsing snowflake
TRIMexpression including removing characters separated by comma.https://docs.snowflake.com/en/sql-reference/functions/trim
Example of real failing sql